Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for analyzers and multifields #4574

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jun 28, 2017

This PR enhances fields.yml to support analyzer, search_analyzer, norms and multi_fields. Currently multi_fields are only supported for text fields. Norms is still disabled by default but can now be overwritten. Below is an example on the usage:

fields:
  - name: phrase
    type: text
    multi_fields:
      - name: raw
        type: keyword
      - name: english
        type: text
        analyzer: english
        search_analyzer: englishenhanced
        norms: true

Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@beniwohli
Copy link
Contributor

Awesome stuff @ruflin! Can't wait to use this

Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a quick manual test with the fields.yml from our APM receiver, works very nicely!

@exekias
Copy link
Contributor

exekias commented Jun 28, 2017

Could you add a changelog entry?

@ruflin ruflin force-pushed the extend-fieldsyml-capabilities branch from 2ddecc7 to 3263129 Compare June 28, 2017 10:38
@ruflin
Copy link
Member Author

ruflin commented Jun 28, 2017

@exekias added

@@ -58,7 +58,8 @@ https://github.com/elastic/beats/compare/v6.0.0-alpha2...master[Check the HEAD d
*Affecting all Beats*

- New cli subcommands interface. {pull}4420[4420]
- Allow source path matching in `add_docker_metadata` processor {pull}4495[4495]
- Allow source path matching in `add_docker_metadata` processor. {pull}4495[4495]
Add support for analyzers and multifields in fields.yml. {pull}4574[4574]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems leading - is missing

This PR enhances fields.yml to support `analyzer`, `search_analyzer`, `norms` and `multi_fields`. Currently `multi_fields` are only supported for `text` fields. Norms is still disabled by default but can now be overwritten. Below is an example on the usage:

```
fields:
  - name: phrase
    type: text
    multi_fields:
      - name: raw
        type: keyword
      - name: english
        type: text
        analyzer: english
        search_analyzer: englishenhanced
        norms: true
```
@ruflin ruflin force-pushed the extend-fieldsyml-capabilities branch from 3263129 to b301961 Compare June 28, 2017 10:45
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@exekias exekias merged commit 2463fd8 into elastic:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants