-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for analyzers and multifields #4574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Awesome stuff @ruflin! Can't wait to use this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did a quick manual test with the fields.yml
from our APM receiver, works very nicely!
Could you add a changelog entry? |
2ddecc7
to
3263129
Compare
@exekias added |
CHANGELOG.asciidoc
Outdated
@@ -58,7 +58,8 @@ https://github.com/elastic/beats/compare/v6.0.0-alpha2...master[Check the HEAD d | |||
*Affecting all Beats* | |||
|
|||
- New cli subcommands interface. {pull}4420[4420] | |||
- Allow source path matching in `add_docker_metadata` processor {pull}4495[4495] | |||
- Allow source path matching in `add_docker_metadata` processor. {pull}4495[4495] | |||
Add support for analyzers and multifields in fields.yml. {pull}4574[4574] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems leading -
is missing
This PR enhances fields.yml to support `analyzer`, `search_analyzer`, `norms` and `multi_fields`. Currently `multi_fields` are only supported for `text` fields. Norms is still disabled by default but can now be overwritten. Below is an example on the usage: ``` fields: - name: phrase type: text multi_fields: - name: raw type: keyword - name: english type: text analyzer: english search_analyzer: englishenhanced norms: true ```
3263129
to
b301961
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFG
This PR enhances fields.yml to support
analyzer
,search_analyzer
,norms
andmulti_fields
. Currentlymulti_fields
are only supported fortext
fields. Norms is still disabled by default but can now be overwritten. Below is an example on the usage: