Aerospike module #4560
Aerospike module #4560
Conversation
|
Can one of the admins verify this patch? |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
alexshadow007
force-pushed
the
module/aerospike
branch
from
897e603 to
f6eaad1
Compare
|
Jenkins test it |
There was a problem hiding this comment.
Awesome contribution! I've to say I'm impressed by the quality of this PR, congrats! 🎉
I left some minor comments, also, could you add an integration test (like https://github.com/elastic/beats/blob/master/metricbeat/tests/system/test_apache.py), it should make it easier to ensure all fields are documented :)
|
|
||
| config := struct{}{} | ||
|
|
||
| logp.Warn("EXPERIMENTAL: The aerospike namespace metricset is experimental") |
There was a problem hiding this comment.
We now offer logp.Experimental, could you change this to use it?
| @@ -0,0 +1,8 @@ | |||
| == aerospike Module | |||
|
|
|||
| This is the aerospike Module. It uses http://www.aerospike.com/docs/reference/info [Info command ] to collect metrics. | |||
There was a problem hiding this comment.
spurious space after Info command?
alexshadow007
force-pushed
the
module/aerospike
branch
from
f6eaad1 to
1d0b830
Compare
alexshadow007
force-pushed
the
module/aerospike
branch
from
1d0b830 to
6841750
Compare
|
@exekias Done |
|
Thank you for this awesome contribution @alexshadow007, this is ready to go from my POV, could you add an entry to |
|
@exekias Done |
|
@alexshadow007 Do you happen to have a dashboard created for this module? It would be nice to include one as well. |
It uses http://www.aerospike.com/docs/reference/info to collect metrics.