Add kernel.failure_mode config option #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
feature/mb/kernel-failure-mode
branch
from
25bd056 to
986c747
Compare
This make the kernel's failure mode configurable from Metricbeat (see the docs changes more details). Another change was made to disable kernel auditing when Metricbeat stops since it will no longer be receiving messages.
andrewkroh
force-pushed
the
feature/mb/kernel-failure-mode
branch
from
986c747 to
653cc0c
Compare
tsg
reviewed
Jun 19, 2017
| options are `silent`, `log`, or `panic`. `silent` basically makes the kernel | ||
| ignore the errors, `log` makes the kernel write the audit messages using | ||
| `printk` so they show up in system's syslog, and `panic` causes the kernel to | ||
| panic to prevent use of the machine. Metricbeat's default is `silent`. |
There was a problem hiding this comment.
By this description sounds like log would be a good choice for the default as well? Or do you think it might spam the kernel logs?
There was a problem hiding this comment.
The spam to the kernel logs was my main motivation for choosing silent over log for the default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make the kernel's failure mode configurable from Metricbeat (see the docs changes more details).
Another change was made to disable kernel auditing when Metricbeat stops since it will no longer be receiving messages.
This PR includes changes from elastic/go-libaudit#8.