-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kernel.audit_rules config option to set audit rules #4482
Add kernel.audit_rules config option to set audit rules #4482
Conversation
099b043
to
ad06c40
Compare
NOTICE
Outdated
|
||
|
||
-------------------------------------------------------------------- | ||
github.com/stretchr/testify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure we had at least this one already, I wonder if duplicates are somehow created here in the NOTICE file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally added an uncommitted NOTICE file when updating the go-libaudit vendor copy. Then the vendor/github.com/elastic/go-libaudit/NOTICE
file was include in the beat NOTICE file
ad06c40
to
a069964
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking awesome, left a minor question
metricbeat/metricbeat.full.yml
Outdated
@@ -126,6 +126,11 @@ metricbeat.modules: | |||
kernel.rate_limit: 0 | |||
kernel.include_raw_message: false | |||
kernel.include_warnings: false | |||
kernel.audit_rules: | | |||
# Define audit rules here. | |||
# Create file watches (-a) or syscall audits (-a or -A). For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I'm not familiar with audit rules, this comment refers to '-w /etc/passwd` or the next line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was suppose to refer to them both, but has a typo. It should say "Create file watches (-w)...". Will fix.
This PR adds the ability to have Metricbeat install audit rules to the kernel.
Metricbeat supports adding both file watch rules (
-w
) and syscall rules (-a
or-A
). The format for specifying rules is the same as with auditd. For example, both of these are supported.This PR depends on elastic/go-libaudit#7.