Only attempt loading the ES template if ES output is enabled #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to raise an error if any template setting was set but the ES output wasn't enabled. This caused problems with the new Metricbeat config, which sets template settings in the configuration. Also removes the code that enables the template loading on `-setup`, because template loading is by default enabled anyway. Fixes elastic#4435.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to raise an error if any template setting was set but
the ES output wasn't enabled. This caused problems with the new
Metricbeat config, which sets template settings in the configuration.
Also removes the code that enables the template loading on
-setup,because template loading is by default enabled anyway.
Fixes #4435.