Template setting in the configuration file #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ruflin
approved these changes
May 10, 2017
| "refresh_interval": "5s", | ||
| "mapping": common.MapStr{ | ||
| "total_fields": common.MapStr{ | ||
| "limit": defaultTotalFieldsLimit, |
There was a problem hiding this comment.
Does this work on all ES versions down to 2.x?
There was a problem hiding this comment.
I think ES 2.x will just ignore the setting, but I'm going to test it.
There was a problem hiding this comment.
Just tested, seems to work well.
| Fields string `config:"fields"` | ||
| Overwrite bool `config:"overwrite"` | ||
| OutputToFile string `config:"output_to_file"` | ||
| Settings map[string]interface{} `config:"settings"` |
There was a problem hiding this comment.
+1 on using a "generic" approach
|
Part of #3654 |
14 tasks
This allows adding and overwriting index/template settings via the
configuration file.
Example config:
setup.template.settings:
index.number_of_shards: 1
index.number_of_replicas: 1
Needed for elastic#4112, part of elastic#3654.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows adding and overwriting index/template settings via the
configuration file.
Example config:
Needed for #4112.
ToDOs: