Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet dashboards #4138

Merged
merged 3 commits into from
May 7, 2017
Merged

Kubelet dashboards #4138

merged 3 commits into from
May 7, 2017

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Apr 28, 2017 •
edited
Loading

This PR:

  • Unifies field names for kubelet modules
  • Adds initial dashboard (Kubernetes overview)
  • Renames module kubelet -> kubernetes

image

Related to #3965

@exekias exekias added in progress Pull request is currently in progress. Metricbeat Metricbeat review labels Apr 28, 2017
@exekias exekias force-pushed the kubelet-dashboards branch 2 times, most recently from da93514 to 544136a Compare May 2, 2017 16:59
@exekias exekias force-pushed the kubelet-dashboards branch from 544136a to 9d73b91 Compare May 2, 2017 17:24
@exekias exekias removed the in progress Pull request is currently in progress. label May 4, 2017
@exekias exekias changed the title [WIP] Kubelet dashboards Kubelet dashboards May 4, 2017
@exekias
Copy link
Contributor Author

exekias commented May 4, 2017

I'm happy to merge this now, as everything seems compatible with the other incoming module: https://github.com/elastic/beats/compare/master...exekias:kube-state-metrics?expand=1

I prefer to do 2 different PRs to make review easier

@monicasarbu
Copy link
Contributor

LGTM. Thanks @exekias for the dashboard.

@monicasarbu monicasarbu merged commit c6c25f5 into elastic:master May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monicasarbu monicasarbu monicasarbu approved these changes

Assignees
No one assigned
Labels
Metricbeat Metricbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exekias @monicasarbu