Fix race in go-metrics adapater #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
bug
libbeat
needs_backport
urso
force-pushed
the
fix/go-metrics-race
branch
from
451297b to
8d0d8e1
Compare
Fix race in go-metrics adapter, if registry is updated concurrently from multiple go routines.
urso
force-pushed
the
fix/go-metrics-race
branch
from
8d0d8e1 to
7eaaec3
Compare
urso
removed
the
needs_backport
|
Can you also backport this to the 5.4 branch, please? I added the |
urso
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race in go-metrics adapter, if registry is updated concurrently from
multiple go routines.