Fix JSON panic #4042
Merged
Fix JSON panic #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
needs_backport
There can be a panic in the JSON decoding code if the input JSON line contains "null" as a string, because that unmarshals without errors but results in a nil map.
andrewkroh
approved these changes
Apr 18, 2017
There was a problem hiding this comment.
LGTM. Good catch. I'm surprised it didn't panic on line 45 when reading from the nil map.
tsg
added a commit
to tsg/beats
that referenced
this pull request
Apr 19, 2017
There can be a panic in the JSON decoding code if the input JSON line contains "null" as a string, because that unmarshals without errors but results in a nil map. (cherry picked from commit aec81e3)
monicasarbu
pushed a commit
that referenced
this pull request
Apr 20, 2017
tsg
added a commit
to tsg/beats
that referenced
this pull request
Apr 24, 2017
There can be a panic in the JSON decoding code if the input JSON line contains "null" as a string, because that unmarshals without errors but results in a nil map. (cherry picked from commit aec81e3)
ruflin
pushed a commit
that referenced
this pull request
Apr 24, 2017
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
There can be a panic in the JSON decoding code if the input JSON line contains "null" as a string, because that unmarshals without errors but results in a nil map. (cherry picked from commit f5ad15f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be a panic in the JSON decoding code if the input JSON line contains
"null" as a string, because that unmarshals without errors but results in a nil
map.
The added test was panicking before the change.