Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental Kibana module to Metricbeat #3895

Merged
merged 1 commit into from
Apr 10, 2017

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Apr 3, 2017

The Kibana module is marked experimental as it might change or removed at any time.

"version": c.Dict("version", s.Schema{
"number": c.Str("number"),
}),
"status": c.Dict("status", s.Schema{
Copy link
Member Author

@ruflin ruflin Apr 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsg I wanted to do here state.overall = status.overall.state but couldn't find a way in schema. Any hints?

@ruflin ruflin force-pushed the mb-kibana-module branch 3 times, most recently from c6ee482 to 082e973 Compare April 3, 2017 18:31
@joegallo
Copy link

joegallo commented Apr 6, 2017

I did a quick compare and contrast between the output of api/status for a recent Kibana (it happens to be 5.2.2) and for an older Kibana (4.6.4). Generally the shape of things is pretty similar, but Kibana 4.6.4 reports "id" for statuses, not "name" and it lacks many of the top level elements (uuid, version, name, buildNum, etc).

I read the code briefly, but not being an expert I'll just ask: does this support 4.6.4?

Unrelated to the above, it wasn't clear to me whether you support custom headers like filebeat does. That's a really important thing for me.

@joegallo
Copy link

joegallo commented Apr 6, 2017

It looked like I needed to sign in to Kibana in order to hit api/status manually (otherwise I just got redirected to the login page) -- is there a configuration option for username/password for this? (there's a reference in the documentation to configuration-metricbeat and I've tried to follow it through but I'm a bit lost in the configuration documentation, so again, just asking.)

@ruflin
Copy link
Member Author

ruflin commented Apr 7, 2017

Auth for all metricsets will be added here: #3945

The Kibana module is marked experimental as it might change or removed at any time.
@ruflin ruflin force-pushed the mb-kibana-module branch from 082e973 to 5bb43b4 Compare April 10, 2017 11:38
}
)

type OverallMetrics struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint] reported by reviewdog 🐶
exported type OverallMetrics should have comment or be unexported

@tsg tsg merged commit ca6caf1 into elastic:master Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants