Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modules yml files permission on Deb #3879

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Fix modules yml files permission on Deb #3879

merged 1 commit into from
Apr 3, 2017

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Mar 31, 2017 •
edited
Loading

The fix in #3645 had a bug (chmod executed on the wrong folder). This fixes the fix and also adds permissions checks to the tests.

@tsg tsg added in progress Pull request is currently in progress. review labels Mar 31, 2017
@tsg tsg requested a review from andrewkroh March 31, 2017 13:43
@tsg
Copy link
Contributor Author

tsg commented Mar 31, 2017

jenkins, package it

1 similar comment
@tsg
Copy link
Contributor Author

tsg commented Apr 2, 2017

jenkins, package it

@tsg
Copy link
Contributor Author

tsg commented Apr 2, 2017

Package tests went green: http://build-eu-00.elastic.co/job/beats-package-PR/91/

@tsg tsg force-pushed the fix_permissions_deb branch from 6fe15f8 to 3d59ad0 Compare April 3, 2017 08:14
Fix modules yml files permission on Deb
af3166f 
The fix in elastic#3645 had a bug (chmod executed on the wrong folder). This fixes the fix and also adds permissions checks to the tests.
@tsg tsg force-pushed the fix_permissions_deb branch from 3d59ad0 to af3166f Compare April 3, 2017 08:15
@tsg
Copy link
Contributor Author

tsg commented Apr 3, 2017

jenkins, package it

@tsg tsg added :Packaging needs_backport PR is waiting to be backported to other branches. v5.3.1 v6.0.0-alpha1 and removed in progress Pull request is currently in progress. labels Apr 3, 2017
@andrewkroh andrewkroh merged commit 37ae2fc into elastic:5.3 Apr 3, 2017
@tsg tsg mentioned this pull request Apr 3, 2017
Merged
@tsg tsg removed the needs_backport PR is waiting to be backported to other branches. label Apr 3, 2017
tsg added a commit to tsg/beats that referenced this pull request Apr 5, 2017
@tsg
Fix modules yml files permission on Deb (elastic#3879)
cff7672 
The fix in elastic#3645 had a bug (chmod executed on the wrong folder). This fixes the fix and also adds permissions checks to the tests.
(cherry picked from commit 37ae2fc)
ruflin pushed a commit that referenced this pull request Apr 6, 2017
@tsg @ruflin
Fix modules yml files permission on Deb (#3879) (#3893)
e3bc8a5 
The fix in #3645 had a bug (chmod executed on the wrong folder). This fixes the fix and also adds permissions checks to the tests.
(cherry picked from commit 37ae2fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees
No one assigned
Labels
:Packaging review v6.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsg @andrewkroh