Cherry-pick #3671 to 5.x: Fix elasticsearch url parsing #3849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use regex to check if host given contains the protocol scheme. If scheme is missing, prepend before attempting to parse the complete URL (cherry picked from commit 1391731)
ruflin
reviewed
Mar 30, 2017
CHANGELOG.asciidoc
Outdated
| @@ -45,6 +45,8 @@ https://github.com/elastic/beats/compare/v5.3.0...master[Check the HEAD diff] | |||
| *Affecting all Beats* | |||
|
|
|||
| - Update index mappings to support future Elasticsearch 6.X. {pull}3778[3778] | |||
| - Add `_id`, `_type`, `_index` and `_score` fields in the generated index pattern. {pull}3282[3282] | |||
There was a problem hiding this comment.
Good catch! It wasn't in the initial one. I will delete it manually.
|
@ruflin Done! When merging, please using the squash option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #3671 to 5.x branch. Original message:
use regex to check if host given contains the protocol scheme. If scheme is
missing, prepend before attempting to parse the complete URL