Remove deprecated geoip feature #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
libbeat
Packetbeat
review
in progress
ruflin
force-pushed
the
remove-deprecated-geoip
branch
from
fb38898 to
53cc6c7
Compare
|
@monicasarbu Would be great to get your input on this one. Are there other parts that should be removed related to topology? |
5 tasks
|
Needs a rebase now. |
ruflin
force-pushed
the
remove-deprecated-geoip
branch
from
5d1d8a2 to
48f6ce9
Compare
|
@tsg rebased |
|
Is this one still in progress? |
ruflin
added
review
and removed
in progress
|
@tsg nope, forgot to change the label. |
tsg
reviewed
Mar 27, 2017
CHANGELOG.asciidoc
Outdated
| @@ -31,6 +31,7 @@ https://github.com/elastic/beats/compare/v5.1.1...master[Check the HEAD diff] | |||
| - Change fieldnames couchbase.node.couch.*.actual_disk_size.* to couchbase.node.couch.*.disk_size.* {pull}3545[3545] | |||
|
|
|||
| *Packetbeat* | |||
| - Remove deprecated geoip | |||
There was a problem hiding this comment.
Can you add the PR number, please?
|
There's a set of geoip files in the system tests which can be probably deleted as well: |
Geoip was deprecated in 5.0 and is now removed for 6.0.
ruflin
force-pushed
the
remove-deprecated-geoip
branch
from
44a181b to
2c57ec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geoip was deprecated in 5.0 and is now removed for 6.0.