Unify fields generated file across all beats #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each beat has its own way of generating the fields.yml file. Some have `_meta/fields.yml`, others `_meta/fields.generated.yml`. All scripts that used the fields.yml file had to do checks for these files and include the `libbeat/_meta/fields.generate.yml` file to get all data in. Now all beats will create `_meta/fields.generated.yml`. In case it does not exist, it is just a copy of `_meta/fields.yml` and will be automatically generated. In addition the file `_meta/fields.full.generated.yml` was introduced, which also contains the content from the `libbeat/_meta/fields.generate.yml`. This file can be used in most scripts to get all fields. The scripts were changed / simplified accordingly. This simplifies the implementation of dynamic template loading as only 1 file has to be taken into account. Part of elastic#3654
14 tasks
monicasarbu
approved these changes
Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each beat has its own way of generating the fields.yml file. Some have
_meta/fields.yml, others_meta/fields.generated.yml. All scripts that used the fields.yml file had to do checks for these files and include thelibbeat/_meta/fields.generate.ymlfile to get all data in. Now all beats will create_meta/fields.generated.yml. In case it does not exist, it is just a copy of_meta/fields.ymland will be automatically generated. In addition the file_meta/fields.full.generated.ymlwas introduced, which also contains the content from thelibbeat/_meta/fields.generate.yml. This file can be used in most scripts to get all fields. The scripts were changed / simplified accordingly.This simplifies the implementation of dynamic template loading as only 1 file has to be taken into account.
Part of #3654