Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local timestamp to event #3622

Closed

Conversation

ohadravid
Copy link
Contributor

@ohadravid ohadravid commented Feb 20, 2017

Hi!
I want to add a tiny change to the wineventlog.
Currently only the UTC time (which is saved in the event xml) is included in the event.
It is very useful to also get the event time in the local timezone of the computer.
This is the same behavior as the Windows Event Viewer (shows the event local time).

image

@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@ruflin ruflin added discuss Issue needs further discussion. Winlogbeat labels Feb 20, 2017
@andrewkroh
Copy link
Member

It is very useful to also get the event time in the local timezone of the computer.

How are you using the local timestamp? In what ways is it more useful than UTC timestamp?

@ohadravid
Copy link
Contributor Author

For example, you can build a query to check if a user tried to login into the machine in a strange time (say 02:00AM). For this, you have to know what the local time of the machine is (and the network might span a number of timezones, so we can't assume to know the timezone of a specific machine).

Another example is monitoring heavy background processes which are configured to run only at night, and we want to make sure they run at the configured time correctly.

@andrewkroh
Copy link
Member

Those are similar to the reasons I was thinking this would be useful information.

We had another request for timezone info in #2887. I think we should consider a more general approach (in libbeat) that allows this to be added in any Beat where a user wants it (as determined via configuration).

@elastic/beats WDYT about an optional local timestamp?

@ruflin
Copy link
Member

ruflin commented Feb 23, 2017

@andrewkroh +1 on having a "processor" or something similar for this. Then we can nest it under its own namespace and have it extendable with additional info.

@monicasarbu
Copy link
Contributor

@ohadravid Thank you for your PR. It seems that there is an interest in finding the local timestamp. We had a short discussion between us and decided that a better solution would be to export the timezone together with the @timestamp in UTC, in order to find the local timestamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. Winlogbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants