Fix $GOPATH/src paths in generated README #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"go install" won't work when beats is not installed in the GOPATH (e.g., it's vendored). Fixes #2974
7AC
referenced
this pull request
Feb 16, 2017
Currently cookiecutter is needed to generate a beat. This adds an additional dependency to generate a beat and does not give us a lot of control over which checks should be executed during execution. As our template is quite simple it can be done with basic string replacements. A simple python script is now done for the task which leads to less inputs needed by the user and allows us to do checks like GOPATH setup etc. The script could potentially be done in Golang but the setup of python is needed anyways for development. Further changes: * Rename .go files to .go.tmpl so they are not checked for correct syntax * Update documentation NOTES: * Changes for the metricbeat generator will follow in a second PR. * Blog post about creating a beat should be updated to point to 5.1. See #3197
The beat needs to go in $GOPATH/src instead of $GOPATH Fixes aristanetworks/openconfigbeat#4
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
|
jenkins, test it |
|
@7AC Thanks for fixing the README. Unfortunately CI didn't help to detect this one :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
srcprefix was missing