Remove exclude pattern from all visualizations #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicasarbu
added
in progress
monicasarbu
changed the title
monicasarbu
force-pushed
the
remove_exclude_pattern
branch
from
b3b72cc to
cdf505f
Compare
andrewkroh
approved these changes
Feb 7, 2017
|
There were failures on this one, but I'm merging it because the failures are not related to the dashboards, and we need this for 5.2.1 |
monicasarbu
added a commit
to monicasarbu/beats
that referenced
this pull request
Feb 7, 2017
(cherry picked from commit 360a3da)
monicasarbu
removed
the
needs_backport
tsg
pushed a commit
that referenced
this pull request
Feb 7, 2017
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
(cherry picked from commit ddd60fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the GitHub issue,
exclude patterndoesn't work anymore in Kibana. This PR is removing theexclude patternfrom the visualizations to fix the issue.For the NFS errors visualization, a new search is needed after removing of the exclude pattern. The search selects all the NFS errors. We consider a NFS error if the
nfs.statusis different thanNFS_OKandNFSERR_NOENT.cc-ed @andrewkroh