Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace *regexp.Regexp with match.Matcher #3469

Merged
merged 6 commits into from
Jan 27, 2017
Merged

Replace *regexp.Regexp with match.Matcher #3469

merged 6 commits into from
Jan 27, 2017

Conversation

urso
Copy link

@urso urso commented Jan 25, 2017 •
edited
Loading

replace regular expressions used for matching a string only with match.Matcher in all beats.

  • libbeat processor changes:
    • unify handling of strings/regexp. Both handle string, []string and try to convert to string if input is no string
    • use match.Match for contains and regexp conditionals

@urso urso added review discuss Issue needs further discussion. in progress Pull request is currently in progress. and removed review labels Jan 25, 2017
@urso urso force-pushed the enh/use-string-matcher branch from 26f9154 to 6b71a78 Compare January 26, 2017 15:53
@urso urso added review and removed discuss Issue needs further discussion. in progress Pull request is currently in progress. labels Jan 26, 2017
@andrewkroh andrewkroh merged commit 3fce440 into elastic:master Jan 27, 2017
@urso urso deleted the enh/use-string-matcher branch February 19, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urso @andrewkroh