Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Update compatibility function to remove processor description on ES < 7.9.0 #27774

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Update Filebeat compatibility function to remove processor description field on ES < 7.9.0

Why is it important?

Users with new versions of Filebeat and ES versions < 7.9.0 will run into errors when loading module ingest pipelines. See https://discuss.elastic.co/t/filebeat-v7-14-0-error-in-loading-pipeline/283407

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 7, 2021
@legoguy1000 legoguy1000 force-pushed the processor-description-compat branch from 1099e30 to e31e68e Compare September 7, 2021 14:08
@legoguy1000 legoguy1000 force-pushed the processor-description-compat branch from e31e68e to 9a04d4a Compare September 7, 2021 14:12
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 7, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-07T19:44:31.510+0000

  • Duration: 99 min 57 sec

  • Commit: f699141

Test stats 🧪

Test Results
Failed 0
Passed 15260
Skipped 2314
Total 17574

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 15260
Skipped 2314
Total 17574

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the godoc here.

filebeat/fileset/compatibility.go Outdated Show resolved Hide resolved
@andrewkroh andrewkroh requested a review from adriansr September 7, 2021 14:30
Co-authored-by: Andrew Kroh <[email protected]>
@andrewkroh
Copy link
Member

run tests

@andrewkroh andrewkroh added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify Filebeat Filebeat review Team:Security-External Integrations labels Sep 7, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@legoguy1000
Copy link
Contributor Author

@andrewkroh Any ideas on the test that failed?

@andrewkroh
Copy link
Member

run tests

@andrewkroh
Copy link
Member

I think it's not related to these changes.

@andrewkroh andrewkroh merged commit 6e290c8 into elastic:master Sep 8, 2021
mergify bot pushed a commit that referenced this pull request Sep 8, 2021
…ion on ES < 7.9.0 (#27774)

* Update Filebeat compatibility function to remove processor description field on ES < 7.9.0

* Fix function description

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit 6e290c8)

# Conflicts:
#	filebeat/fileset/compatibility.go
#	filebeat/fileset/compatibility_test.go
mergify bot pushed a commit that referenced this pull request Sep 8, 2021
…ion on ES < 7.9.0 (#27774)

* Update Filebeat compatibility function to remove processor description field on ES < 7.9.0

* Fix function description

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit 6e290c8)

# Conflicts:
#	filebeat/fileset/compatibility.go
#	filebeat/fileset/compatibility_test.go
@legoguy1000 legoguy1000 deleted the processor-description-compat branch September 8, 2021 11:37
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Sep 9, 2021
* master: (39 commits)
  [Heartbeat] Move JSON tests from python->go (elastic#27816)
  docs: simplify permissions for Dockerfile COPY (elastic#27754)
  Osquerybeat: Fix osquery logger plugin severy levels mapping (elastic#27789)
  [Filebeat] Update compatibility function to remove processor description on ES < 7.9.0 (elastic#27774)
  warn log entry and no validation failure when both queue_url and buck… (elastic#27612)
  libbeat/cmd/instance: ensure test config file has appropriate permissions (elastic#27178)
  [Heartbeat] Add httpcommon options to ZipURL (elastic#27699)
  Add a header round tripper option to httpcommon (elastic#27509)
  [Elastic Agent] Add validation to ensure certificate paths are absolute. (elastic#27779)
  Rename dashboards according to module.yml files for master (elastic#27749)
  Refactor vagrantfile, add scripts for provisioning with docker/kind (elastic#27726)
  Accept syslog dates with leading 0 (elastic#27775)
  [Filebeat] Add timezone config option to decode_cef and syslog input (elastic#27727)
  [Filebeat] Threatintel compatibility updates (elastic#27323)
  Add support for ephemeral containers in elastic agent dynamic provider (elastic#27707)
  [Filebeat] Integration tests in CI for AWS-S3 input (elastic#27491)
  Fix flakyness of TestFilestreamEmptyLine (elastic#27705)
  [Filebeat] kafka v2 using parsers (elastic#27335)
  Update Kafka version parsing / supported range (elastic#27720)
  Update Sarama to 1.29.1 (elastic#27717)
  ...
andrewkroh added a commit that referenced this pull request Sep 9, 2021
…ion on ES < 7.9.0 (#27774)

* Update Filebeat compatibility function to remove processor description field on ES < 7.9.0

* Fix function description

Co-authored-by: Andrew Kroh <[email protected]>
andrewkroh added a commit that referenced this pull request Sep 10, 2021
…ion on ES < 7.9.0 (#27774) (#27805)

* Update Filebeat compatibility function to remove processor description field on ES < 7.9.0

* Fix function description

Co-authored-by: Alex Resnick <[email protected]>
Co-authored-by: Andrew Kroh <[email protected]>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
…ion on ES < 7.9.0 (elastic#27774)

* Update Filebeat compatibility function to remove processor description field on ES < 7.9.0

* Fix function description

Co-authored-by: Andrew Kroh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify Filebeat Filebeat review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants