Fix negative response times for MongoDB. #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message timestamp could have was accidentally reused from an old message in the same stream. For example, in this sequence of messages in the same stream: * `REPLY1` (with no matching request) * `REQUEST2` * `REPLY2` packetbeat was correctly matching the REQUEST2 with REPLY2 but was using the timestamp of REPLY1 for computing the response time. The fix is to simply through away the message and wait for it to be created with the new message received. Should fix most of the issues from #216. This also removes parseOffset and bytesReceived from the stream struct as they were not used.
|
@tsg Looks good. Should we do the same for Redis? https://github.com/elastic/packetbeat/blob/master/protos/redis/redis.go#L296 |
|
+1 Checked all protocols. Only redis and mongodb use this logic when resetting the Stream for new messages. All other protocols should be fine. |
Same as for MongoDB, this can be a cause of negative response times.
|
Right, I guess the Redis code is where this came from originally. I changed it there as well, tests still pass. |
ruflin
added a commit
that referenced
this pull request
Sep 8, 2015
Fix negative response times for MongoDB.
urso
pushed a commit
that referenced
this pull request
Dec 2, 2015
Update to most recent libbeat version and shared files
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Jan 20, 2016
Fix negative response times for MongoDB.
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Jan 20, 2016
send @metadata.beat to Logstash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message timestamp could have been accidentally reused from an
old message in the same stream. For example, in this sequence of
messages in the same stream:
REPLY1(with no matching request)REQUEST2REPLY2packetbeat was correctly matching the REQUEST2 with REPLY2 but was using
the timestamp of REPLY1 for computing the response time. The fix is to
simply through away the message and wait for it to be created with the
new message received.
Should fix most of the issues from #216.
This also removes parseOffset and bytesReceived from the stream struct as
they were not used.