-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packetbeat ipv6 #2254
Packetbeat ipv6 #2254
Conversation
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
@raboof LGTM, great contribution! While we wait for the CLA, can you also add a line in the |
I added it under 'Breaking changes' as it might break consumers that assume IP's to be in IPv4 format.
@karmi the Corporate CLA was 'Signed and Filed' (by Mark Bakker) this morning, are there any further steps I need to take? Do we need to do anything to make the bot aware of this? |
@raboof The script can't verify corporate CLA's automatically. I did the manual check and all looks good. |
jenkins, test it |
I'm not sure I understand this, on my testing it's still using the IPV4 dotted format for IPs. Also, the PR add support for matching processes when using IPv6, but the Changelog entry makes it sound like we added support for decoding IPv6 (which we already support). |
@tsg you're right - I've updated the changelog, does that clarify things? |
@raboof Wonderful! Thanks a lot for the contribution. |
👍 thanks for the great framework & for taking our contribution :) |
As discussed in #1995 . The CLA is not yet signed, but expect that Real Soon Now, so code review welcome :)