Use scaled_floats for percentages in ES mapping #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| field["type"] = "float" | ||
|
|
||
| properties[field["name"]] = { | ||
| "type": field.get("type") | ||
| } | ||
|
|
||
| if field["type"] == "scaled_float": | ||
| properties[field["name"]]["scaling_factor"] = \ | ||
| field.get("scaling_factor", 1000) |
Elasticsearch has recently added scaled_float as an option for storing floating point numbers. The scaled floats are stored internally as longs, which means they can take advantage of the integer compression in Lucene. See elastic/elasticsearch#19264 for details. The PR moves all percentages to scaled floats. In our `fields.yml` we assume a default scaling factor of 1000, which should work well for our percentages (values between 0 and 1). This scaling factor can also be set to a different value in `fields.yml`.
|
Flaky appveyor test should be fixed in #2156 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch has recently added scaled_float as an option for storing floating
point numbers. The scaled floats are stored internally as longs, which means
they can take advantage of the integer compression in Lucene. See
elastic/elasticsearch#19264 for details.
The PR moves all percentages to scaled floats. In our
fields.ymlwe assume adefault scaling factor of 1000, which should work well for our percentages
(values between 0 and 1). This scaling factor can also be set to a different
value in
fields.yml.