-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and map azure-eventhub input fields #20981
Conversation
Pinging @elastic/integrations-platforms (Team:Platforms) |
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mapping fixes LGTM, but I think that long-term we should use azure.eventhub
instead of azure-eventhub
.
description: > | ||
Fields regarding the Azure event hub information. | ||
fields: | ||
- name: azure-eventhub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use underscore to combine words, but in any case I think these metrics should be stored under azure.eventhub
instead of azure-eventhub
. But changing this would be a breaking change (unless we duplicate fields), we would have to decide when to do it. Most likely in 8.0.
Failures in CI seem related. |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label. Could you fix it @narph? 🙏
NOTE: |
This pull request is now in conflicts. Could you fix it? 🙏
|
decided on no renaming |
What does this PR do?
Renames and map azure-eventhub input fields
Why is it important?
Rename and map azure-eventhub input fields, preparation for migration.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues