Do not send empty values in case of errors #2032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to be that we were sending zero values (e.g. "" for string, 0 for int) in case of errors getting a particular value. Fixes elastic#1972.
tsg
added
in progress
|
Closing in favor of #2034 which I think is better. |
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Jul 14, 2016
This is an alternative implementation of elastic#2032. Instead of collecting the errors and then removing the empty values, we define a schema of conversions and we use code apply them, so we have the opportunity to handle errors. Fixes elastic#1972.
urso
pushed a commit
that referenced
this pull request
Jul 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be that we were sending zero values (e.g. "" for string, 0 for int)
in case of errors getting a particular value.
Fixes #1972.
I'm not very happy with this implementations, because it requires a lot of repetition when doing the conversions. I want to try another approach, but I'm opening this one for discussion and to have something to compare the new code against.