Elasticsearch output support for gzip compressed content-encoding #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ruflin Thanks. It's rebased. |
urso
added
review
and removed
in progress
| Password: "", | ||
| Timeout: 90 * time.Second, | ||
| MaxRetries: 3, | ||
| CompressionLevel: 0, |
There was a problem hiding this comment.
Is that a good default? I assume it is what we had before?
There was a problem hiding this comment.
Right, I made the default to match the old behavior. Making compression opt-in instead of opt-out. Default config is debatable, though.
There was a problem hiding this comment.
I somehow expected that some compression as default is good. I assume there is somehow a tradeoff between performance and compression level, but we can figure that out later.
|
LGTM. Waiting for green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support and new configuration option to elasticsearch output to enable gzip based compression of JSON payload in POST requests.
Requires #1834 plus rebase after merging #1834