From ec11850b3cd5e094ff5543fcf29dc4e79b831f89 Mon Sep 17 00:00:00 2001 From: sayden Date: Tue, 5 May 2020 19:36:34 +0200 Subject: [PATCH] Revert unskipping of mssql tests --- .../module/mssql/performance/data_integration_test.go | 8 ++------ .../module/mssql/transaction_log/data_integration_test.go | 8 ++------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/x-pack/metricbeat/module/mssql/performance/data_integration_test.go b/x-pack/metricbeat/module/mssql/performance/data_integration_test.go index f0520a843bd..498fdc1d0de 100644 --- a/x-pack/metricbeat/module/mssql/performance/data_integration_test.go +++ b/x-pack/metricbeat/module/mssql/performance/data_integration_test.go @@ -8,9 +8,6 @@ import ( "net/url" "testing" - "github.com/elastic/beats/v7/libbeat/logp" - "github.com/elastic/beats/v7/libbeat/tests/compose" - _ "github.com/denisenkom/go-mssqldb" "github.com/pkg/errors" "github.com/stretchr/testify/assert" @@ -20,10 +17,9 @@ import ( ) func TestData(t *testing.T) { - logp.TestingSetup() - service := compose.EnsureUp(t, "mssql") + t.Skip("Skipping `data.json` generation test") - f := mbtest.NewReportingMetricSetV2(t, mtest.GetConfig(service.Host(), "performance")) + f := mbtest.NewReportingMetricSetV2(t, mtest.GetConfig("performance")) err := mbtest.WriteEventsReporterV2(f, t, "") assert.NoError(t, err) diff --git a/x-pack/metricbeat/module/mssql/transaction_log/data_integration_test.go b/x-pack/metricbeat/module/mssql/transaction_log/data_integration_test.go index 16f5c16eac6..fcdad6ccb44 100644 --- a/x-pack/metricbeat/module/mssql/transaction_log/data_integration_test.go +++ b/x-pack/metricbeat/module/mssql/transaction_log/data_integration_test.go @@ -7,18 +7,14 @@ package transaction_log import ( "testing" - "github.com/elastic/beats/v7/libbeat/logp" - "github.com/elastic/beats/v7/libbeat/tests/compose" - mbtest "github.com/elastic/beats/v7/metricbeat/mb/testing" mtest "github.com/elastic/beats/v7/x-pack/metricbeat/module/mssql/testing" ) func TestData(t *testing.T) { - logp.TestingSetup() - service := compose.EnsureUp(t, "mssql") + t.Skip("Skipping `data.json` generation test") - f := mbtest.NewReportingMetricSetV2(t, mtest.GetConfig(service.Host(), "transaction_log")) + f := mbtest.NewReportingMetricSetV2(t, mtest.GetConfig("transaction_log")) err := mbtest.WriteEventsReporterV2(f, t, "") if err != nil {