Use dots in field names and make filters pluggable #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
monicasarbu
force-pushed
the
use_dots_field_in_condition
branch
from
3ce4f07 to
cf3bc65
Compare
monicasarbu
force-pushed
the
use_dots_field_in_condition
branch
2 times, most recently
from
a684b5d to
006a567
Compare
| # exported event: | ||
| # event -> filter1 -> event1 -> filter2 ->event2 ... | ||
| # Supported actions: drop_fields, drop_event, include_fields | ||
| # filters: |
There was a problem hiding this comment.
remove the space in front of the config options which should be uncommented. makes it easy to see difference between config and docs
There was a problem hiding this comment.
Good spot. Thanks
monicasarbu
force-pushed
the
use_dots_field_in_condition
branch
2 times, most recently
from
c6730f2 to
3c34957
Compare
|
LGTM |
|
@ruflin I have updated the filters implementation at the Metricbeat module level with the latest changes. |
| # Supported actions: drop_fields, drop_event, include_fields | ||
| #filters: | ||
| #- drop_fields: | ||
| # equals: |
There was a problem hiding this comment.
Not sure if the indentation will be correct, if someone removes all 4 # here? I think one more space for the last 3 is needed?
monicasarbu
force-pushed
the
use_dots_field_in_condition
branch
from
b0fb996 to
9779a43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
.in the condition:equals:
process.pid: 34443
I will update the documentation in a separate PR as well as system tests for Metricbeat.