Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: apm-beats-update disable notifications temporarily #15924

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

kuisathaverat
Copy link
Contributor

until we fix an issue, notifications are temporarily disabled

@kuisathaverat kuisathaverat requested a review from a team January 29, 2020 09:54
@kuisathaverat kuisathaverat self-assigned this Jan 29, 2020
@mdelapenya
Copy link
Contributor

One question, is it possible to conditionally disable this at the library level?

@kuisathaverat kuisathaverat merged commit 5ac111e into elastic:master Jan 29, 2020
@kuisathaverat
Copy link
Contributor Author

if you mean something like notifyBuildResult(enable: false) that would be the same that remove the step, it is not implemented.

@kuisathaverat kuisathaverat deleted the disable-notifications branch January 29, 2020 10:23
@kuisathaverat
Copy link
Contributor Author

Do you mean to check which job trigger the job and decided to send the notification or not? it implies a version of the library each time you add a job, it is not really flexible and hidden a behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants