Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for topbeat flaky test. Maybe, possibly #1518

Merged
merged 1 commit into from
Apr 28, 2016

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Apr 28, 2016

Check that we have a full line before attempting to JSON decode it. See #1517 for the analysis.

Closes #1517.

Check that we have a full line before attempting to JSON decode it. See

Closes elastic#1517.
@tsg tsg added the review label Apr 28, 2016
@codecov-io
Copy link

codecov-io commented Apr 28, 2016

Current coverage is 57.97%

Merging #1518 into master will increase coverage by +4.95%

@@             master      #1518   diff @@
==========================================
  Files           197        175     -22   
  Lines         22280      20403   -1877   
  Methods           0          0           
  Messages          0          0           
  Branches          0          0           
==========================================
+ Hits          11812      11827     +15   
+ Misses         9515       8234   -1281   
+ Partials        953        342    -611   
  1. 4 files (not in diff) in ...beat/sys/wineventlog were deleted. more
  2. 3 files (not in diff) in ...eat/sys/eventlogging were deleted. more
  3. 5 files (not in diff) in winlogbeat/sys were deleted. more
  4. 6 files (not in diff) in winlogbeat/eventlog were deleted. more
  5. 3 files (not in diff) in winlogbeat were deleted. more
  6. 4 files (not in diff) in topbeat/system were modified. more
    • Misses +2
    • Partials -9
    • Hits +7
  7. 2 files (not in diff) in ...etbeat/protos/thrift were modified. more
    • Partials -53
    • Hits +53
  8. 2 files (not in diff) in ...ketbeat/protos/pgsql were modified. more
    • Partials -48
    • Hits +48
  9. 2 files (not in diff) in ...tbeat/protos/mongodb were modified. more
    • Partials -30
    • Hits +30
  10. 5 files (not in diff) in ...beat/protos/memcache were modified. more
    • Partials -52
    • Hits +52

Powered by Codecov. Last updated by 089afc6

@andrewkroh
Copy link
Member

Time will tell...

@andrewkroh andrewkroh merged commit a4281c0 into elastic:master Apr 28, 2016
@tsg tsg deleted the fix_flaky_topbeat_test branch August 25, 2016 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants