Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes Autodiscover docs with the new resources #15055

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Dec 11, 2019

This PR updates documentation now that kubernetes autodiscover provides different resource based discovery.

Codebase changed at #14738

closes #14975

cc: @exekias @odacremolbap @vjsamuel

Signed-off-by: chrismark <[email protected]>
* kubernetes.node.name
* kubernetes.node.uid

====== Service spesific:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
====== Service spesific:
====== Service specific:

* kubernetes.labels
* kubernetes.annotations

====== Pod spesific:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
====== Pod spesific:
====== Pod specific:

Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry approved but saw a typo afterwards

Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
@ChrsMark ChrsMark merged commit f5bb919 into elastic:master Dec 16, 2019
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Dec 16, 2019
ChrsMark added a commit that referenced this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Kubernetes Autodiscover docs with the new resources
3 participants