Log rotation - possibility of log rotations of 2,3,4,5,x minutes or h… #11608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
leopucci
force-pushed
the
leopucci_11365
branch
4 times, most recently
from
411d767 to
febc776
Compare
…ours Adding changelog entry
leopucci
force-pushed
the
leopucci_11365
branch
from
febc776 to
c2eddbc
Compare
|
I am closing this PR as it seems it is the continuation of #11602. Please add your fixes to that original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michalpristas I have correted the tests.
There is a difference that before, you had fixed times and for all other time values an arbitrary time function.
No you can use 1,2,3,4,5 sec/min/hour/etc to rotate the time. As a consequence of being allowed to choose time, you do not have arbitrary time anymore. So I removed the arbitrary tests and the code of it.
Please take a look
This patch solves #11365