Use IndexPrefix for kafka and logstash output. #10841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simitt
added
bug
needs_backport
urso
reviewed
Feb 20, 2019
libbeat/outputs/logstash/logstash.go
Outdated
| @@ -46,7 +46,7 @@ func makeLogstash( | |||
| cfg *common.Config, | |||
| ) (outputs.Group, error) { | |||
| if !cfg.HasField("index") { | |||
| cfg.SetString("index", -1, beat.Beat) | |||
| cfg.SetString("index", -1, beat.IndexPrefix) | |||
There was a problem hiding this comment.
We should separate config unpacking into a separate function and create tests (file config_test.go) for config unpacking edge cases.
common pattern:
func readConfig(in *common.Config) (Config, error) {
...
}
|
Thanks for adding tests. Run |
Output index differed to Elasticsearch output. fixes elastic#10839
simitt
force-pushed
the
master-fix-output-index
branch
from
f7cad52 to
c709710
Compare
|
@urso I update the license headers. Failing test seems unrelated afaics. |
|
I restarted the Travis one. At least one should be green. |
|
jenkins, retest this please |
urso
approved these changes
Feb 25, 2019
simitt
added a commit
to simitt/beats
that referenced
this pull request
Feb 25, 2019
Output index differed to Elasticsearch output. fixes elastic#10839
This was referenced Feb 25, 2019
simitt
added a commit
to simitt/beats
that referenced
this pull request
Feb 25, 2019
Output index differed to Elasticsearch output. fixes elastic#10839
simitt
added a commit
to simitt/beats
that referenced
this pull request
Feb 28, 2019
simitt
added a commit
to simitt/beats
that referenced
this pull request
Feb 28, 2019
simitt
added a commit
to simitt/beats
that referenced
this pull request
Feb 28, 2019
simitt
added a commit
that referenced
this pull request
Feb 28, 2019
simitt
added a commit
that referenced
this pull request
Feb 28, 2019
simitt
added a commit
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing to ES output libbeat falls back to use
beat.Info.IndexPrefixas default index, if nothing else is configured. Using logstash or kafka, libbeat usesbeat.Info.Beatas default index.In case
IndexPrefixandBeatis not the same, the resulting index in ES differs.This PR intends to fix this inconsistency.
fixes #10839