Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _all settings in the 5.x version of the template #4901

Closed
4 tasks done
tsg opened this issue Aug 15, 2017 · 2 comments
Closed
4 tasks done

Remove _all settings in the 5.x version of the template #4901

tsg opened this issue Aug 15, 2017 · 2 comments

Comments

@tsg
Copy link
Contributor

tsg commented Aug 15, 2017

In the 5.x version of the template we currently have:

"_all": { "norms": false}

This breaks after upgrading ES to 6.0, without upgrading the template.

~~We should replace it with:

"_all": { "enabled": false }

Disabling _all is fine, because ES 5.X supports searching all fields without the need of an _all field.~~

We should do this in both 6.0 and 5.6 branches. This will help with the upgrade process.

@tsg
Copy link
Contributor Author

tsg commented Aug 17, 2017

There's an issue with disabling _all:

With _all enabled, searching by one word of a keyword field was working, because all fields were indexed as text in _all. With _all disabled, one would have to search by the full field value, individual words don't match any document.

This leads to two issues that we should discuss:

  • If we disable the _all fields in 5.6, it's a breaking change

  • The _all option doesn't exist in 6.0, we'd need to explicitly simulate it using copy_to to a single text field.

At the very minimum, we'll have to include a line in Breaking changes about this change in behavior.

@tsg tsg changed the title Disable _all field in the 5.x version of the template Remove _all settings in the 5.x version of the template Aug 18, 2017
@tsg
Copy link
Contributor Author

tsg commented Aug 18, 2017

The new plan, due to the issue above, is to remove the _all settings from the 5.6 version of the template. This costs a byte per document, but it's the safest approach.

I'm updating the PRs to reflect this decision.

tsg pushed a commit to tsg/beats that referenced this issue Aug 18, 2017
Part of elastic#4901. The removal of the `norms: false` _all setting results in a storage
increase of one byte per doc, but this smooths the upgrade experience.
tsg pushed a commit to tsg/beats that referenced this issue Aug 18, 2017
Part of elastic#4901. The removal of the `norms: false` costs one byte per
doc, but makes the upgrade experience a bit more smooth.
@tsg tsg removed the discuss Issue needs further discussion. label Aug 18, 2017
exekias pushed a commit that referenced this issue Aug 18, 2017
Part of #4901. The removal of the `norms: false` _all setting results in a storage
increase of one byte per doc, but this smooths the upgrade experience.
exekias pushed a commit that referenced this issue Aug 18, 2017
Part of #4901. The removal of the `norms: false` costs one byte per
doc, but makes the upgrade experience a bit more smooth.
tsg added a commit to tsg/beats that referenced this issue Aug 18, 2017
Part of elastic#4901. The removal of the `norms: false` _all setting results in a storage
increase of one byte per doc, but this smooths the upgrade experience.

(cherry picked from commit 33c0897)
exekias pushed a commit that referenced this issue Aug 18, 2017
Part of #4901. The removal of the `norms: false` _all setting results in a storage
increase of one byte per doc, but this smooths the upgrade experience.

(cherry picked from commit 33c0897)
@tsg tsg closed this as completed Aug 18, 2017
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
…stic#4948)

Part of elastic#4901. The removal of the `norms: false` _all setting results in a storage
increase of one byte per doc, but this smooths the upgrade experience.

(cherry picked from commit d6ed786)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant