-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename add_locale to add_timezone #4350
Comments
I just realised that we add independent of the format config all under the same field. Based on this |
Currently there are two mutually exclusive formats -- How about a rename to
and you can pick and choose which to add.
|
SGTM: I somehow thought we have 3 but seems like we dropped one option: #3974 (comment) The above will also work with more options. |
I don't think there much benefit to rename it now. It's been released for too long and adopted by many configs. |
The new
add_locale
processor adds time zone information to events. I think it would be more clear to simply call itadd_timezone
. So let's rename it and update the documentation.The text was updated successfully, but these errors were encountered: