Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename add_locale to add_timezone #4350

Closed
andrewkroh opened this issue May 18, 2017 · 4 comments
Closed

Rename add_locale to add_timezone #4350

andrewkroh opened this issue May 18, 2017 · 4 comments
Labels

Comments

@andrewkroh
Copy link
Member

The new add_locale processor adds time zone information to events. I think it would be more clear to simply call it add_timezone. So let's rename it and update the documentation.

@ruflin
Copy link
Member

ruflin commented May 18, 2017

I just realised that we add independent of the format config all under the same field. Based on this add_timezone makes more sense but I would argue that dependent on the config options a different field should be added, like beat.locale.timezone, beat.locale.*. So if someone queries for one of the fields or wants to do some processing on it, the format will always be the same.

@andrewkroh
Copy link
Member Author

Currently there are two mutually exclusive formats -- offset and abbreviation.

How about a rename to add_timezone and make the fields

  • beat.timezone.offset
  • beat.timezone.abbrev

and you can pick and choose which to add.

processors:
- add_timezone:
    fields: [offset, abbrev]

@ruflin
Copy link
Member

ruflin commented May 18, 2017

SGTM: I somehow thought we have 3 but seems like we dropped one option: #3974 (comment) The above will also work with more options.

@andrewkroh
Copy link
Member Author

I don't think there much benefit to rename it now. It's been released for too long and adopted by many configs.

@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants