Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Add feature flag to the system metricsets to control whether metrics failures mark agent as degraded #40543

Open
cmacknz opened this issue Aug 15, 2024 · 1 comment
Assignees
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@cmacknz
Copy link
Member

cmacknz commented Aug 15, 2024

This is a follow up to #40542, where we made partial metrics collection keep the agent healthy to minimize customer disruption for non-fatal errors.

Once we are confident we have fixed the source of the most common partial metrics collection errors we should return to having agent report itself as degraded when metrics collection fails in our own tests as a quality gate. This allows new errors to be easily flagged to us before release.

The current known issues preventing us from doing this by default are:

We should add a feature flag to the system module or the system metrics that turns this functionality on or off, and turn it on in the Elastic Agent integration tests. Adding this as part of the system integration configuration allows it to be controlled through the configuration of the system/metrics input and system integration without needing changes to the Elastic Agent control protocol.

Acceptance Criteria:

  • A module or metricset level configuration flag exists controlling whether non-fatal system metrics collection errors report as degraded or healthy.
  • The configuration flag has the agent report as degraded on error in all Elastic Agent integration tests and all tests in https://github.com/elastic/integrations/tree/main/packages
@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 15, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

No branches or pull requests

3 participants