Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document headers and ssl for metricsets #3948

Closed
ruflin opened this issue Apr 7, 2017 · 2 comments · Fixed by #7967
Closed

Document headers and ssl for metricsets #3948

ruflin opened this issue Apr 7, 2017 · 2 comments · Fixed by #7967

Comments

@ruflin
Copy link
Member

ruflin commented Apr 7, 2017

In #3945 customer headers, auth and ssl was introduced for all http metricsets. The following must be done:

  • Add documentation for it
  • Add it to the full config

Potentially also find a way on how to test it.

@joegallo
Copy link

joegallo commented Apr 7, 2017

One quick things that's not 100% clear to me:

For elasticsearch.output, I would specify:

    hosts: ["somehost"]
    username: "someusername"
    password: "somepassword"
    headers:
      SomeHeader: SomeValue

But it looks like perhaps the username and password auth for metricsets has been implemented purely as additional headers only? So no username/password -- just have to gen up an Authorization header myself. Is that correct or did I misunderstand?

If I did understand correctly, I guess this comment in then an enhancement request to handle username and passwords specially. (That might be pie in the sky, though, but it doesn't hurt to ask. :D)

@ruflin
Copy link
Member Author

ruflin commented Apr 13, 2017

@joegallo Sorry for the late reply. The above change does not include username / password. But you can pass username/password as part of the host and it will be automatically extracted to create the correct headers and will also not be logged.

+1 on having also general support for the fields username and password as part of http. Could you open a feature request for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants