Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/{cel,httpjson}: make DisableKeepAlives configurable #33951

Closed
efd6 opened this issue Dec 5, 2022 · 1 comment · Fixed by #34014
Closed

x-pack/filebeat/input/{cel,httpjson}: make DisableKeepAlives configurable #33951

efd6 opened this issue Dec 5, 2022 · 1 comment · Fixed by #34014
Labels
Filebeat Filebeat

Comments

@efd6
Copy link
Contributor

efd6 commented Dec 5, 2022

The cel and httpjson inputs both disable keep-alives unconditionally (here and here). This can lead to negative performance impacts in some cases.

We should consider allowing the user to specify this behaviour, defaulting to the current behaviour.

When this is done the input should be properly checked to ensure that bodies are always read to completion and closed to prevent resource loss. In both cases this looks to be true. Relevant code:

  • cel: all HTTP requests deserialise there body through respToMap which reads the full body and closes it here.
  • httpjson: all HTTP requests are made via the *httpClient.do method which closes in a defer here, and reads the full body in drainBody
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants