Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with obtaining reviewdog #21976

Closed
advancedwebdeveloper opened this issue Oct 19, 2020 · 4 comments
Closed

Problems with obtaining reviewdog #21976

advancedwebdeveloper opened this issue Oct 19, 2020 · 4 comments
Assignees
Labels
bug Team:Integrations Label for the Integrations team

Comments

@advancedwebdeveloper
Copy link

Hi.
Here is my situation:

$make lint
go: downloading golang.org/x/lint v0.0.0-20200302205851-738671d3881b
go: found golang.org/x/lint/golint in golang.org/x/lint v0.0.0-20200302205851-738671d3881b
go: downloading github.com/haya14busa/reviewdog v0.10.2
go: found github.com/haya14busa/reviewdog/cmd/reviewdog in github.com/haya14busa/reviewdog v0.10.2
go get: github.com/haya14busa/[email protected]: parsing go.mod:
module declares its path as: github.com/reviewdog/reviewdog
but was required as: github.com/haya14busa/reviewdog
make: *** [Makefile:142: lint] Error 1

$ go version
go version go1.15.2 gollvm LLVM 12.0.0git linux/amd64

$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/oceanfish81/.cache/go-build"
GOENV="/home/oceanfish81/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/oceanfish81/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/oceanfish81/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/oceanfish81/gollvm_dist"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/oceanfish81/gollvm_dist/tools"
GCCGO="/home/oceanfish81/gollvm_dist/bin/llvm-goc"
AR="ar"
CC="/usr/bin/clang"
CXX="/usr/bin/clang++"
CGO_ENABLED="1"
GOMOD="/home/oceanfish81/beats/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build107471361=/tmp/go-build -gno-record-gcc-switches -funwind-tables"

CC @haya14busa @shogo82148

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 19, 2020
@shogo82148
Copy link
Contributor

Hi, Can you try this fix? #21981
It works in my environment.

% make lint
go: found github.com/reviewdog/reviewdog/cmd/reviewdog in github.com/reviewdog/reviewdog v0.10.2
go: found golang.org/x/lint/golint in golang.org/x/lint v0.0.0-20200302205851-738671d3881b
reviewdog -diff "git diff master"
2020/10/19 23:37:43 reviewdog: [start]	runner=golint
2020/10/19 23:41:35 reviewdog: [finish]	runner=golint

@ycombinator ycombinator added the Team:Integrations Label for the Integrations team label Oct 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 19, 2020
@andresrc
Copy link
Contributor

We are not using this tool anymore, it might be removed.

@urso
Copy link

urso commented Oct 22, 2020

There is an optional pre-commit hook one can install via make setup-commit-hooks. The pre-commit hook will run make lint, which runs reviewdoc in order to check if commits have any lint errors. Given the number of lint messages we get from multiple packages it is not widely used.

The fix and backports have been merged. Closing.

@urso urso closed this as completed Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

6 participants