Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Disable upgrade capability of Agent #21001

Closed
ruflin opened this issue Sep 7, 2020 · 7 comments · Fixed by #21206
Closed

[Elastic Agent] Disable upgrade capability of Agent #21001

ruflin opened this issue Sep 7, 2020 · 7 comments · Fixed by #21206
Assignees

Comments

@ruflin
Copy link
Contributor

ruflin commented Sep 7, 2020

With #20205 Fleet will be able to upgrade an Agent. But not in all cases upgrade of Agents should be enabled. Some examples:

  • Agent running Docker should be upgraded through the container
  • Agent administrator wants to use his own tooling for upgrade
  • Agent does not have the permissions, no root.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@neptunian
Copy link
Contributor

@ruflin Should we also be guarding against trying to upgrade if their version is < 7.10 in which case it's not possible to upgrade it?

@ph
Copy link
Contributor

ph commented Sep 23, 2020

@neptunian Yes I think this is a good idea. a lot of things changed between 7.9 and 7.10, structure on disk etc.

@ruflin
Copy link
Contributor Author

ruflin commented Sep 24, 2020

Perhaps we can turn this on the head to simplify things. An Elastic Agent must report that it is upgradable, so the default is it is not. Like this we don't have to cover all the special cases where it is not but the Agent does.

@blakerouse
Copy link
Contributor

@ruflin I like that idea, Agent should tell Kibana, yes I am upgradable, then Kibana should do the version comparison.

@ph
Copy link
Contributor

ph commented Sep 24, 2020

👍 Good plan @ruflin.

@blakerouse
Copy link
Contributor

The #21206 branch now includes the logic to prevent upgrading of Elastic Agent unless the conditions are correct.

I filed #21318 to cover the reporting aspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants