Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PRs to use PR ID in the artifact name #20274

Closed
mdelapenya opened this issue Jul 28, 2020 · 2 comments · Fixed by #20282
Closed

Support PRs to use PR ID in the artifact name #20274

mdelapenya opened this issue Jul 28, 2020 · 2 comments · Fixed by #20282
Assignees
Labels
Team:Automation Label for the Observability productivity team

Comments

@mdelapenya
Copy link
Contributor

When packaging a PR, the generated artifact is uploaded to a Google Cloud bucket with the name of the snapshot. We'd like to generate the artifact including the PR ID:

- gs://beats-ci-artifacts/snapshots/elastic-agent-8.0.0-SNAPSHOT-linux-x86_64.tar.gz
+ gs://beats-ci-artifacts/pull-requests/elastic-agent-8.0.0-SNAPSHOT-${PR_ID}-linux-x86_64.tar.gz

cc/ @elastic/observablt-robots @ph @EricDavisX

@mdelapenya mdelapenya added the Team:Automation Label for the Observability productivity team label Jul 28, 2020
@mdelapenya mdelapenya self-assigned this Jul 28, 2020
@mdelapenya
Copy link
Contributor Author

Revisiting the mage build tools, and to avoid refactoring it to support creating the packages with a different name, I think we can use another schema for the bucket layout:

gs://beats-ci-artifacts/pull-requests/pr-123/elastic-agent-8.0.0-SNAPSHOT-linux-x86_64.tar.gz

@kuisathaverat wdyt?

@ph
Copy link
Contributor

ph commented Jul 28, 2020

@mdelapenya +1 for not changing the artifact names, the Elastic-Agent relies on that quite heavily and with the upgrade this will only increase.

@michalpristas and @blakerouse for info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants