Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Add ADC support for googlecloud module #18454

Closed
kaiyan-sheng opened this issue May 12, 2020 · 3 comments
Closed

[Metricbeat] Add ADC support for googlecloud module #18454

kaiyan-sheng opened this issue May 12, 2020 · 3 comments
Labels
enhancement Stalled Team:Platforms Label for the Integrations - Platforms team

Comments

@kaiyan-sheng
Copy link
Contributor

kaiyan-sheng commented May 12, 2020

Google Cloud client libraries use a strategy called Application Default Credentials (ADC) to find your application's credentials. When your code uses a client library, the strategy checks for your credentials in the following order:

  1. First, ADC checks to see if the environment variable GOOGLE_APPLICATION_CREDENTIALS is set. If the variable is set, ADC uses the service account file that the variable points to.
  2. If the environment variable isn't set, ADC uses the default service account that Compute Engine, Google Kubernetes Engine, Cloud Run, App Engine, and Cloud Functions provide, for applications that run on those services.
  3. If ADC can't use either of the above credentials, an error occurs.

This issue is to track the work of adding ADC support into Metricbeat, similar to what #15668 is done for Filebeat.

Note: also needs to consider if there's enough code between Filebeat/Metricbeat around credentials to move to x-pack/libbeat/common directory.

@kaiyan-sheng kaiyan-sheng added enhancement Team:Platforms Label for the Integrations - Platforms team labels May 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic
Copy link

botelastic bot commented Apr 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Apr 26, 2021
@botelastic botelastic bot closed this as completed May 26, 2021
@zube zube bot removed the [zube]: Done label Aug 25, 2021
@lesaux
Copy link

lesaux commented Aug 1, 2023

I have a feeling this has never been implemented, or the docs haven't been updated.

json keys are baaaad...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Stalled Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

No branches or pull requests

4 participants