Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes autodiscover: add/restructure variables from resources #16059

Closed
odacremolbap opened this issue Feb 4, 2020 · 2 comments
Closed
Labels
autodiscovery candidate Candidate to be added to the current iteration containers Related to containers use case Stalled Team:Platforms Label for the Integrations - Platforms team

Comments

@odacremolbap
Copy link
Contributor

Recently autodiscover for kubernetes was refactored to allow different resources to be used:
#14738

Node identification (stored at the host variable) uses the external IP, and if not present internal IP. There are also more addresses present at the structure which we should consider using

On a related matter autodiscover for pods and services might also need to be expanded to address exposed ports by number or name, use CNAMES when availables, considering all kinds of services, and headless services to pod scenarios.
#15796

Not requested (yet) but probably something that we will need to consider to keep variables for autodiscover homogeneus are ingresses, since they share most of the aforementioned variables.

@odacremolbap odacremolbap added Team:Platforms Label for the Integrations - Platforms team autodiscovery containers Related to containers use case labels Feb 4, 2020
@arthurh4
Copy link

Hello, @odacremolbap

I've been looking into heartbeat for kubernetes and it's really amazing. Using it we can let our devs setup heartbeat monitors directly from CICD pipeline through YAML labels. We would like to also add the feature for external services like ExternalName services (CNAME). it would be very very appreciated !

Looking at. the code it should not be that complicated:

	host := svc.Spec.ClusterIP.   
        // If a service doesn't have an IP then dont monitor it. 
	if host == "" && flag != "stop" {. 
		return. 
	}

We mostly need to add a handler for externalIP:

NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
google-com ExternalName google.com 80/TCP 106m

Do you have any plan on implemtenting this ? Thanks a lot

@botelastic
Copy link

botelastic bot commented Mar 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Mar 13, 2021
@botelastic botelastic bot closed this as completed Apr 12, 2021
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Apr 12, 2021
@zube zube bot removed the [zube]: Done label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery candidate Candidate to be added to the current iteration containers Related to containers use case Stalled Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

No branches or pull requests

3 participants