Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the oracle metricbeat module to GA #14279

Closed
9 of 10 tasks
andresrc opened this issue Oct 28, 2019 · 4 comments
Closed
9 of 10 tasks

Move the oracle metricbeat module to GA #14279

andresrc opened this issue Oct 28, 2019 · 4 comments
Assignees
@sayden
Labels
:integrations Metricbeat Metricbeat needs_team Indicates that the issue/PR needs a Team:* label v7.7.0

Comments

@andresrc
Copy link
Contributor

andresrc commented Oct 28, 2019 •
edited by sayden
Loading

For a metricset to go GA, the following criterias should be met:

  • Supported versions are documented
  • Supported operating systems are documented (if applicable)
  • Integration tests exist
  • System tests exist
  • Automated checks that all fields are documented. (Awaiting a wati to run Python tests only in Jenkins or Travis will always fail.
  • Documentation
  • Fields follow ECS and naming conventions
  • Dashboards exists (if applicable)
  • Kibana Home Tutorial (if applicable)
  • Open PR against Kibana repo with tutorial. Examples can be found here.
    data.json exists and an automated way to generate it exists (go test -data`)
  • Test environment in Docker exist for integration tests
@andresrc andresrc added Metricbeat Metricbeat Team:Integrations Label for the Integrations team v7.6.0 labels Oct 28, 2019
@sayden sayden mentioned this issue Mar 10, 2020
Merged
@sayden
Copy link
Contributor

sayden commented Mar 17, 2020

We have the library available in the docker image of Metricbeat but we have just realized that the Oracle docker image also requires accepting an EULA before download, so we'll have to work on this now.

@sayden sayden mentioned this issue Mar 24, 2020
Merged
@andresrc
Copy link
Contributor Author

can we close this one?

@sayden
Copy link
Contributor

sayden commented Apr 1, 2020

Only the automated check for documented fields is missing because of some issue in the CI yet

@masci masci closed this as completed Dec 17, 2020
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Dec 17, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 17, 2020
@botelastic
Copy link

botelastic bot commented Dec 17, 2020

This issue doesn't have a Team:<team> label.

@zube zube bot removed the [zube]: Done label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sayden sayden

Labels
:integrations Metricbeat Metricbeat needs_team Indicates that the issue/PR needs a Team:* label v7.7.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@masci @andresrc @sayden