Fix an issue where ConfigBlocksEqual was returning false #10587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
approved these changes
Feb 5, 2019
The ordering was not preserved when comparing the values for conflict blocks which result in multiple reload on each fetch even if the configuration didn't change.
ph
force-pushed
the
fix/configuration-equals
branch
from
05c65b9 to
6c96763
Compare
|
rebase because of #10582 |
ph
added a commit
to ph/beats
that referenced
this pull request
Feb 6, 2019
* Fix an issue where ConfigBlocksEqual was returning false The ordering was not preserved when comparing the values for conflict blocks which result in multiple reload on each fetch even if the configuration didn't change. (cherry picked from commit 20809e1)
ph
added
v6.7.0
and removed
needs_backport
urso
pushed a commit
to urso/beats
that referenced
this pull request
Feb 6, 2019
* Fix an issue where ConfigBlocksEqual was returning false The ordering was not preserved when comparing the values for conflict blocks which result in multiple reload on each fetch even if the configuration didn't change. (cherry picked from commit 20809e1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering was not preserved when comparing the values for conflict
blocks which result in multiple reload on each fetch even if the
configuration didn't change.