Skip to content

Commit

Permalink
Add tags to docker images (#3557)
Browse files Browse the repository at this point in the history
Some Dockerfiles were missing a tag for the image that should be pulled and used :latest. As latest can change over time, this could break CI builds. To make it consistent each Dockerfile must link to a specific version
  • Loading branch information
ruflin authored and tsg committed Feb 10, 2017
1 parent d4cb00a commit b3a7291
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion metricbeat/module/ceph/_meta/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ceph/demo
FROM ceph/demo:tag-build-master-jewel-centos-7

ENV MON_IP 0.0.0.0
ENV CEPH_PUBLIC_NETWORK 0.0.0.0/0
Expand Down
2 changes: 2 additions & 0 deletions metricbeat/module/kafka/_meta/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# TODO: No tags currently exist for this image. Tags should be used whever possible
# as otherwise builds are not identical over time.
FROM spotify/kafka

EXPOSE 2181 9092
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/module/php_fpm/_meta/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM richarvey/nginx-php-fpm
FROM richarvey/nginx-php-fpm:php71

RUN echo "pm.status_path = /status" >> /usr/local/etc/php-fpm.d/www.conf
ADD ./php-fpm.conf /etc/nginx/sites-enabled
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/module/prometheus/_meta/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
FROM prom/prometheus
FROM prom/prometheus:v1.5.1

EXPOSE 9090

0 comments on commit b3a7291

Please sign in to comment.