Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture "number of documents modified/deleted" for operations on document stores #161

Open
axw opened this issue Oct 28, 2019 · 0 comments

Comments

@axw
Copy link
Member

axw commented Oct 28, 2019

Problem description

This is an offshoot of #112. That issue is scoped to SQL databases, which typically report the number of "rows affected" in response to DML statements (INSERT, UPDATE, DELETE, ...).

The solution for that specific issue (report "rows_affected") does not make sense for document stores, such as Elasticsearch and MongoDB. At least those two separate the number of modifications/updates vs. deletions, and they do not operate on rows but rather documents, thus "rows_affected" is not sensible here.

Solution proposal

Introduce the following span context:

  • context.db.docs_modified (created or updated)
  • context.db.docs_deleted

How they are stored in Elasticsearch is TBD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant