Introduce metricset.name #4857
Merged
Introduce metricset.name #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
|
jalvz
approved these changes
Feb 22, 2021
| @@ -1,7 +1,7 @@ | |||
| Elastic APM Server | |||
| Copyright 2014-2021 Elasticsearch BV | |||
|
|
|||
| This product includes software developed by The Apache Software | |||
| This product includes software developed by The Apache Software | |||
There was a problem hiding this comment.
I dunno what's up, I just ran make update. I'll look closer if it happens again 🤷
v1v
added a commit
to v1v/apm-server
that referenced
this pull request
Feb 22, 2021
…chemas-to-agents * upstream/master: (111 commits) Introduce metricset.name (elastic#4857) processor/otel: test service.version handling (elastic#4853) docs: Add PHP agent information to shared docs (elastic#4740) Script for faster development workflow (elastic#4731) Update to elastic/beats@1b31c26 (elastic#4763) backport: add 7.12 to .backportrc.json (elastic#4807) backport: enable auto-merge on backport PRs (elastic#4777) Support for Node.js profiles (elastic#4728) docs: readds .NET link (elastic#4764) [DOCS] Fixes URLs on Secure communication with APM Agents page (elastic#4746) ci: set proper parameters for the tar step (elastic#4696) docs: add 7.11.1 release notes (elastic#4727) Disable sourcemap upload endpoint when data streams enabled (elastic#4735) Add service name to dataset field (elastic#4674) Update to elastic/beats@ba423212a660 (elastic#4733) sampling: require a default policy (elastic#4729) processor/otel: add unit test for span status (elastic#4734) Add support for consuming OTLP/gRPC metrics (elastic#4722) [apmpackage] Add config options supported in ESS (elastic#4690) Use the apm-server version everywhere* (elastic#4725) ...
v1v
added a commit
to v1v/apm-server
that referenced
this pull request
Feb 22, 2021
…te-schema-json-1 * upstream/master: (111 commits) Introduce metricset.name (elastic#4857) processor/otel: test service.version handling (elastic#4853) docs: Add PHP agent information to shared docs (elastic#4740) Script for faster development workflow (elastic#4731) Update to elastic/beats@1b31c26 (elastic#4763) backport: add 7.12 to .backportrc.json (elastic#4807) backport: enable auto-merge on backport PRs (elastic#4777) Support for Node.js profiles (elastic#4728) docs: readds .NET link (elastic#4764) [DOCS] Fixes URLs on Secure communication with APM Agents page (elastic#4746) ci: set proper parameters for the tar step (elastic#4696) docs: add 7.11.1 release notes (elastic#4727) Disable sourcemap upload endpoint when data streams enabled (elastic#4735) Add service name to dataset field (elastic#4674) Update to elastic/beats@ba423212a660 (elastic#4733) sampling: require a default policy (elastic#4729) processor/otel: add unit test for span status (elastic#4734) Add support for consuming OTLP/gRPC metrics (elastic#4722) [apmpackage] Add config options supported in ESS (elastic#4690) Use the apm-server version everywhere* (elastic#4725) ...
axw
added a commit
to axw/apm-server
that referenced
this pull request
Mar 25, 2021
* Add metricset.name field to metrics docs * aggregation/txmetrics: set metricset.name * aggregation/spanmetrics: set metricset.name * Add changelog entry # Conflicts: # changelogs/7.12.asciidoc # include/fields.go
axw
added a commit
that referenced
this pull request
Mar 25, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
* Add metricset.name field to metrics docs * aggregation/txmetrics: set metricset.name * aggregation/spanmetrics: set metricset.name * Add changelog entry (cherry picked from commit 5f72138) # Conflicts: # changelogs/7.12.asciidoc # include/fields.go # x-pack/apm-server/aggregation/txmetrics/aggregator_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Add an optional
metricset.namefield to metrics docs. Set it to "transaction" for transaction histogram metrics, and "service_destination" for service destination (span) metrics.Checklist
How to test these changes
Enable transaction and service destination aggregation, check that metric documents have a
metricset.namefield with value equal to either "transaction" or "service_destination".Related issues
Partially implements #4392. Still need to handle breakdown metrics, and "app" metrics.