Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop storing unsampled transactions #5997

Closed
simitt opened this issue Aug 20, 2021 · 4 comments · Fixed by #6514
Closed

Stop storing unsampled transactions #5997

simitt opened this issue Aug 20, 2021 · 4 comments · Fixed by #6514
Labels
v8.0.0
Milestone
8.0

Comments

@simitt
Copy link
Contributor

simitt commented Aug 20, 2021

Stop storing unsampled transactions by setting apm-server.sampling.keep_unsampled: false.

This probably breaks alerting and ML job. Figure out what needs to be done to make this a smooth change with as little user impact as possible. (Collaborate with the @elastic/apm-ui team on this).
@simitt simitt added the v8.0.0 label Aug 20, 2021
@simitt simitt added this to the 8.0 milestone Aug 20, 2021
@simitt simitt mentioned this issue Aug 20, 2021
Closed
@zube zube bot added the [zube]: Backlog label Aug 20, 2021
@sorenlouv
Copy link
Member

Alerting now uses transaction metrics when enabled. Correlations and ML jobs are still WIP.

@graphaelli
Copy link
Member

Depends on elastic/kibana#108466

@vigneshshanmugam vigneshshanmugam mentioned this issue Sep 29, 2021
Closed
@simitt
Copy link
Contributor Author

simitt commented Oct 27, 2021

@axw is going to create a proposal, also related to #6260 and #6223.

@axw
Copy link
Member

axw commented Nov 1, 2021

Proposal: https://docs.google.com/document/d/17wNGGh3u53tQsl938FZmQBa-If8TFKEGyto-Jvjzobk/edit

@axw axw mentioned this issue Nov 3, 2021
Merged
2 tasks
@axw axw closed this as completed in #6514 Nov 4, 2021
@zube zube bot removed the [zube]: Done label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v8.0.0
Projects
None yet
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

Remove apm-server.sampling.keep_unsampled config axw/apm-server
4 participants
@graphaelli @sorenlouv @axw @simitt