-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Support for APM Agent Central Config with zero configuration #4573
Comments
Created a Kibana issue to track work for this for Fleet elastic/kibana#89311 |
Reopening and changing the description so we don't lose sight of enabling this feature without manually injecting API Keys. |
Fleet provides extension points for the package policy create and update APIs. Information courtesy of Paul Tavares:
So what we should be able to do is have the APM app hook into these API calls, and inject one or more additional API Keys. This could be done without elastic/kibana#89311. Alternatively/additionally we could use the same mechanism to inject APM agent config into APM package policies. When a package policy is created or updated we would inject the APM agent config through the hook, and in subsequent changes to APM agent config we would update the package policy to keep them in sync. With this kind of approach we would need an alternative means of marking agent config as "applied". I think the latter approach is probably what we should aim for, but in the near term we should keep the number of changes down and inject additional privileges. This will be necessary anyway for tail-based sampling. |
In scenarios where the Kibana API Key needs to be revoked, I believe it is fair to let the users revoke it manually. But we would need a way to convince the hook to actually create a new one. |
No direct work on the APM Server side, created elastic/kibana#93420 for the suggested solution. |
We have elastic/kibana#93420 for the interim solution, and I've just opened #5018 and elastic/kibana#95501 for the final solution. Closing this one, let's iterate on those issues as needed. |
See elastic/kibana#93420 (comment) for proof of concepts |
Agent central config depends on APM Server querying Kibana, and having privileges as laid out in https://www.elastic.co/guide/en/apm/server/current/privileges-agent-central-config.html.
When running under Fleet, APM Server will by default not have the necessary privileges to query central config. We will have to either inject secondary credentials for querying Kibana, or somehow extend the privileges of the primary API Key provided by Fleet to APM Server.
Users should not need to care about configuring API Keys for this; they should rather be concerned about enabling or disabling the central config feature, which implicitly updates privileges.
Alternatively: we can reimplement APM Agent Central Config to use Fleet. We would need to:
The text was updated successfully, but these errors were encountered: