Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APM Server should not record negative durations #3715

Closed
axw opened this issue Apr 29, 2020 · 2 comments · Fixed by #3721
Closed

APM Server should not record negative durations #3715

axw opened this issue Apr 29, 2020 · 2 comments · Fixed by #3721
Assignees
@axw
Labels
bug
Milestone
7.8

Comments

@axw
Copy link
Member

axw commented Apr 29, 2020

Agents can currently send negative transaction and span durations to the APM Server, which will happily record them. We should either reject them, or clamp them to zero.
@axw axw added the bug label Apr 29, 2020
@axw axw mentioned this issue Apr 29, 2020
Merged
@graphaelli graphaelli added this to the 7.8 milestone Apr 29, 2020
@graphaelli
Copy link
Member

Discussed irl, let's reject the metricset to force a fix in the reporter rather than dropping quietly.

@axw axw self-assigned this Apr 30, 2020
@axw axw mentioned this issue Apr 30, 2020
Merged
6 tasks
@axw
Copy link
Member Author

axw commented Apr 30, 2020

Closed by #3721

@axw axw closed this as completed Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axw axw

Labels
bug
Projects
None yet
Milestone
7.8
Development

Successfully merging a pull request may close this issue.

docs/spec: require duration >= 0 axw/apm-server
2 participants
@graphaelli @axw